Advertisement
 

Membership

 

Advertisement

 

Advertisement

 
Forums \ StarCraft forum \ 1.16.1 repfix (pause/chat)
1, 2, 3 
Information
Small stars represents one level - This user is on level 4Small stars represents one level - This user is on level 4Small stars represents one level - This user is on level 4Small stars represents one level - This user is on level 4
texas
1.16.1 repfix (pause/chat) (7898 reads, 42 replies, 3 years ago)
RepFix is a BWL/ChaosLauncher plugin which fixes StarCraft's (1.16.1) crash when watching a replay with chat text recorded while game was paused.

Download: http://depositfiles.com/files/vbqbjcfx4

The bug itself seems to be very old.
Basically replay action processing looks like:
1) read the actions for next tick and copy actions data to the buffer
2) wait until that tick comes, read actions from the buffer and execute

When game is paused tick remains unchanged, so every chat message written while game paused has been recorded with that tick when game was paused.
The problem is in that the buffer in which actions are copied for execution is too small. I believe about 12 messages are enough to make it overflow. And when overflow happens the data overrides neighbor memory areas in which are other variables located.The consequences can be very different and depend on amount of messages has been recorded during pause.

What I did is a replacement of static buffer with dynamic one.
1) when copying actions to the buffer:
1.1) when overwrite - allocate new buffer, write data to the new buffer
1.2) when append (multiple actions for a single tick) - append to the previously allocated buffer increasing its size if needed
2) when reading from a static buffer - return a pointer to the dynamic buffer instead of static

Plugin patches StarCraft's code, so use it on your own risk!

I will be very appreciated for any testing/bugreports.
Later I will merge this fix into ICCup Launcher.

Thanks.


PS: I believe the main mistake of BW developers was to count chat text as game action. I would rather record/read it in a different way. But I'm not the one who decide ^^

UPDATE: v. 0.0.0.2 should work online now.
UPDATE: v. 0.0.0.3 fixed action loss in bnet-mode.


Thx Python_Max for this excellent work!

source: iCCup
☆★☆ FIREBATHERO ★☆★
This post was edited by its author @ 3 years ago
Quote  
 

3 years ago
#1
Big stars represents five levels - This user is on level 11 Big stars represents five levels - This user is on level 11
Small stars represents one level - This user is on level 11
EffOrt
Wow nice, needed this but sadly I deleted the replay =(.
Quote  

3 years ago
#2
Small stars represents one level - This user is on level 2Small stars represents one level - This user is on level 2
gns.i-jasa
This comment has been censored ("nuked") by the GosuGamers Crew.

3 years ago
#3
Big stars represents five levels - This user is on level 5
vAN_dAL
thx for info mate
Longer I play... worse I play
Quote  

3 years ago
#4
Big stars represents five levels - This user is on level 11 Big stars represents five levels - This user is on level 11
Small stars represents one level - This user is on level 11
ostojiy
yay ~ moar pluggins :D
Quote  

3 years ago
#5
Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3
ronin[bwd]
I can't even find the enable CPU throttling checkbox _ _;; It isn't under the speed options in the game menu
This post was edited by its author @ 3 years ago
Quote  

3 years ago
#6
Moto.Kah
it works on some replays... but other replays corrupt... or while watching some replays the game is paused and u can't unpause.
Quote  

3 years ago
#7
Moto.Kah
this is complete shit and corrupts replays that wouldn't be corrupted without it.. and doesn't even work with all replays that would be corrupted... it's 50/50 chance on reps that u pause then talk a lot.. maybe lower chance...

test plz before u post
Quote  

3 years ago
#8
Moto.Kah
ROFL. i just watched a replay of game i just played.. and replay major corrupted and zerg player's drones killed eachother.. while my production stopped at 10/10 cuz i had no supply depot and my scvs never did anything.. -_____________---------------

EDIT: replay works fine without plugin
This post was edited by its author @ 3 years ago
Quote  

3 years ago
#9
Moto.Kah
This comment has been censored ("nuked") by the GosuGamers Crew.
This post was edited by its author @ 3 years ago

3 years ago
#10
Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3
Python_Max
<BM skipped>

Could you please give me your "corrupted" replay?
If you read what I said - I was asking for testing, not trolling. Thanks.
This post was edited by its author @ 3 years ago
Quote  

3 years ago
#11
This user is a member of the GosuCrew
Big stars represents five levels - This user is on level 10 Big stars represents five levels - This user is on level 10
JiYan (GosuBet Manager SC (inactive))
is this in iccup right now?
Quote  

3 years ago
#12
Moto.Kah
This comment has been censored ("nuked") by the GosuGamers Crew.

3 years ago
#13
Big stars represents five levels - This user is on level 9
Small stars represents one level - This user is on level 9Small stars represents one level - This user is on level 9Small stars represents one level - This user is on level 9Small stars represents one level - This user is on level 9
AnyTime
#12 stop with caps lock, pls. You're getting more annoying. -.-
Quote  

3 years ago
#14
Moto.Kah
This comment has been censored ("nuked") by the GosuGamers Crew.

3 years ago
#15
Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3
Python_Max
I've asked you for a replay where
i just watched a replay of game i just played.. and replay major corrupted and zerg player's drones killed eachother.. while my production stopped at 10/10 cuz i had no supply depot and my scvs never did anything..


But you're trolling again...
Sure I did, it works fine for me. If there is a problem, then its obviously replay dependent.
This post was edited by a forum moderator @ 3 years ago
Quote  

3 years ago
#16
Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3
nuclear
Omg 1.16 is holy shit - I have installed it and I've been dropped, while playing online... so I installed back the old good 1.15.3
Quote  

3 years ago
#17
Moto.Kah
This comment has been censored ("nuked") by the GosuGamers Crew.

3 years ago
#18
Moto.Kah
This comment has been censored ("nuked") by the GosuGamers Crew.

3 years ago
#19
Big stars represents five levels - This user is on level 5
ToT)Ashur(
This comment has been censored ("nuked") by the GosuGamers Crew.
This post was edited by its author @ 3 years ago

3 years ago
#20
Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3Small stars represents one level - This user is on level 3
Python_Max
This comment has been censored ("nuked") by the GosuGamers Crew.
This post was edited by its author @ 3 years ago

1, 2, 3 

Forum post
  • Do to others what you would have them do to you.
  • Do not judge so that you will not be judged.

    » Read posting rules in detail

    Reminder: IP-addresses for the comments are saved. Offensive posts will be censored. Repeated offense will result in a warning and/or a temporary account lockdown.
  • 1.16.1 repfix (pause/chat) \ Reply
    To submit a post, you have to be a registred member. Register an account below the title 'Membership' in the left menu.

    » Top of the page


    Advertisement